Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-912: [Customer] CustomerInput improvements #941

Merged
merged 6 commits into from
Oct 2, 2019
Merged

graphQl-912: [Customer] CustomerInput improvements #941

merged 6 commits into from
Oct 2, 2019

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

  • Marked email with ! in CustomerInput.
  • Fixed comment in gender r(.
  • Fixed comments of taxvat field in CustomerInput.

Fixed Issues (if relevant)

  1. [Customer] CustomerInput improvements #912: CustomerInput improvements

lenaorobei
lenaorobei suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address api-functional tests failures.

Vitaliy Boyko added 2 commits September 27, 2019 09:59
Merge branches '2.3-develop' and 'GraphQl-912-CustomerInput-improveme…
eb29ce7 
…nts' of github.com:magento/graphql-ce into GraphQl-912-CustomerInput-improvements

� Conflicts:
�	app/code/Magento/CustomerGraphQl/etc/schema.graphqls
graphQl-912: fixing api functional test
8247d57
@VitaliyBoyko VitaliyBoyko added Contribution Day Tickets is good for start on Contribution Day Event: mageconf19 MageConf 2019 Contribution Day labels Sep 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5960 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team merged commit be95cfa into 2.3-develop Oct 2, 2019
@ghost
Copy link

ghost commented Oct 2, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lenaorobei lenaorobei deleted the GraphQl-912-CustomerInput-improvements branch October 14, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Cleanup Component: CustomerGraphQl Contribution Day Tickets is good for start on Contribution Day Event: mageconf19 MageConf 2019 Contribution Day Partner: Atwix partners-contribution Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliyBoyko @magento-engcom-team @lenaorobei